Skip to content

add integer to roman function #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2020
Merged

add integer to roman function #4050

merged 4 commits into from
Dec 21, 2020

Conversation

Ksengine
Copy link
Contributor

@Ksengine Ksengine commented Dec 21, 2020 •
edited
Loading

integer to roman function

simply added fastest method i found.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Ksengine
add integer to roman function
2336eee 
simply added fastest method i found.
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Dec 21, 2020
@ghost ghost added the tests are failing Do not merge until tests pass label Dec 21, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Dec 21, 2020
cclauss
cclauss approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cclauss cclauss merged commit 0388961 into TheAlgorithms:master Dec 21, 2020
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 21, 2020
@Ksengine
Copy link
Contributor Author

super, @cclauss Thank You!

@Ksengine Ksengine deleted the patch-1 branch December 22, 2020 04:19
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Ksengine @cclauss @stokhos
add integer to roman function (TheAlgorithms#4050)
f9bd9bc 
* add integer to roman function

simply added fastest method i found.

* Rename roman_to_integer.py to roman_numerals.py

* Update roman_numerals.py

* Update roman_numerals.py

Co-authored-by: Christian Clauss <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@Ksengine @cclauss @peRFectBeliever
add integer to roman function (TheAlgorithms#4050)
df92397 
* add integer to roman function

simply added fastest method i found.

* Rename roman_to_integer.py to roman_numerals.py

* Update roman_numerals.py

* Update roman_numerals.py

Co-authored-by: Christian Clauss <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Ksengine @cclauss
add integer to roman function (TheAlgorithms#4050)
7170029 
* add integer to roman function

simply added fastest method i found.

* Rename roman_to_integer.py to roman_numerals.py

* Update roman_numerals.py

* Update roman_numerals.py

Co-authored-by: Christian Clauss <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Ksengine @cclauss @shermanhui
add integer to roman function (TheAlgorithms#4050)
1663b4f 
* add integer to roman function

simply added fastest method i found.

* Rename roman_to_integer.py to roman_numerals.py

* Update roman_numerals.py

* Update roman_numerals.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ksengine @cclauss